beam icon indicating copy to clipboard operation
beam copied to clipboard

Improved test coverage and fix the implementation of Inject and CoGBK

Open forsaken628 opened this issue 3 years ago • 8 comments

Improved test coverage and fix the implementation of Inject and CoGBK

@lostluck #23272


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • [ ] Update CHANGES.md with noteworthy changes.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels Python tests Java tests Go tests

See CI.md for more information about GitHub Actions CI.

forsaken628 avatar Sep 20 '22 15:09 forsaken628

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

github-actions[bot] avatar Sep 20 '22 16:09 github-actions[bot]

Change causes some of the regression tests to fail

https://ci-beam.apache.org/job/beam_PreCommit_Go_Commit/12491/console

I'm a bit indisposed this week due to a summit at work, but when I get a moment I'll see if I can't find what's going wrong with the expectations. The test is correct and required to pass, so the fix needs to be on the direct runner side too.

github.com/apache/beam/sdks/v2/go/test/regression is the package to run against. It should run automatically against the direct runner for you to iterate against.

You shouldn't need to comment "Retest this please" when you push changes, since the precommits run against the direct runner and are failing as a result.

lostluck avatar Sep 20 '22 17:09 lostluck

Codecov Report

Merging #23307 (d2f4145) into master (2955954) will increase coverage by 0.02%. The diff coverage is 82.60%.

@@            Coverage Diff             @@
##           master   #23307      +/-   ##
==========================================
+ Coverage   73.47%   73.49%   +0.02%     
==========================================
  Files         718      718              
  Lines       95878    95883       +5     
==========================================
+ Hits        70443    70467      +24     
+ Misses      24124    24104      -20     
- Partials     1311     1312       +1     
Flag Coverage Δ
go 50.96% <82.60%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/go/pkg/beam/runners/direct/gbk.go 83.59% <82.60%> (+11.23%) :arrow_up:
sdks/go/pkg/beam/runners/direct/direct.go 68.46% <0.00%> (+2.70%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 21 '22 04:09 codecov[bot]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

github-actions[bot] avatar Sep 21 '22 04:09 github-actions[bot]

Run Go Postcommit

lostluck avatar Sep 21 '22 18:09 lostluck

Run Go Flink ValidatesRunner

lostluck avatar Sep 21 '22 18:09 lostluck

Run Go Spark ValidatesRunner

lostluck avatar Sep 21 '22 18:09 lostluck

Run Go Samza ValidatesRunner

lostluck avatar Sep 21 '22 18:09 lostluck

Reminder, please take a look at this pr: @damccorm

github-actions[bot] avatar Sep 29 '22 12:09 github-actions[bot]

Run Go Spark ValidatesRunner

lostluck avatar Oct 10 '22 20:10 lostluck

Run Go Flink ValidatesRunner

lostluck avatar Oct 10 '22 20:10 lostluck

Run Go Postcommit

lostluck avatar Oct 17 '22 16:10 lostluck