Lori A. Burns

Results 474 comments of Lori A. Burns

Thanks for the moving-code PR -- that'll make subequent review much easier. My only surprise was that the original file remained with ~100 loc. I wonder if the dfjk class...

Next commit make this change to fix the Eco (W) lane, https://github.com/psi4/psi4/pull/3302/files#diff-9886b1fe077112c3a9952964ed992dc3cd38b48d0a506a6b7a00241e4669d2b1R192 . Will watch the dftgrac error on Azure to see if it repeats.

> @loriab changed the build system, and it's no longer clear to me how you even build Psi4 with debug symbols. Can you explain how you do that now? I...

I suspect the Py symbols problem is cascading over into Psi4 when I try to pull in the new v1 package: https://dev.azure.com/psi4/psi4/_build/results?buildId=6998&view=logs&j=499f23ba-2d7a-50c4-a0c8-8019c87dbcd5&t=2b8117cc-084c-5b08-03ef-dfd4e0c79dc4&l=27934 . The two gcc lanes have einsums enabled,...

I think you're using `pybind11::embed` on Linux to paper over the problem, that is, to get it to compile. Probably Apple has that don't-require-all-symbols-to-resolve-to-make-the-dylib--wait-till-runtime flag enabled, and that's why it...

It's not actually linked to the python lib https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1229388&view=logs&j=7b6f2c87-f3a7-5133-8d84-7c03a75d9dfc&t=9eb77fd2-8ddd-5444-8fc0-71cb28dcb736&l=2329 (ldd on the conda package). But something about that ein::ein target is incorporating Python. I don't understand what's happening, only that...

Ok, I've found the next proximate cause. After printing out your subtargets, this private_flags one looked likely and sure enough when I removed the `-z defs` to report undefined symbols...

Yup, below does the trick for a clean pytest suite ``` (py313) psilocaluser@bash:psinet:/psi/gits/einsums_clean/build31: (main) git diff diff --git a/CMakeLists.txt b/CMakeLists.txt index 167189a..e0f9443 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -650,7 +650,7...

Thanks! I think I'm in favor of a v1.0.3 with just this change. There might be more later (I've got a separate branch going for pyeinsums work), but this should...

closed by #158, c-f built v1.0.3, and integrated into psi4 in dummy form by 3281 (link above)