psi4 icon indicating copy to clipboard operation
psi4 copied to clipboard

SAPT(DFT) auto compute GRAC

Open Awallace3 opened this issue 1 year ago • 4 comments

Description

I have added an option to compute the necessary GRAC shifts for SAPT(DFT) automatically. I added a little extra logic to "try harder" at converging cations to hopefully fail less often if this option is specified. These changes will enable more users to call SAPT(DFT) more routinely in their workflows without having to consider acquiring GRAC shifts externally through their own logic or tabulated sources.

User API & Changelog headlines

  • [X] User can now specify -99 for GRAC shifts (A and/or B) to automatically compute the shift required for SAPT(DFT) to make the code more accessible to users. Here is the example usage:
    psi4.set_options(
        {        
            "sapt_dft_grac_shift_a": -99,
            "sapt_dft_grac_shift_b": -99,
        }
    )
    psi4.energy("SAPT(DFT)", molecule=mol_dimer)

Dev notes & details

  • [x] Automatically computes SAPT(DFT) GRAC shifts for monomer A and/or B
  • [x] Logic for trying extra options with level shifts to attempt to converge more cations in approximating the ionization potential

Questions

Checklist

Status

  • [x] Ready for review
  • [ ] Ready for merge

Awallace3 avatar Oct 11 '24 21:10 Awallace3

Rebase when #3256 is merged in (there will be a merge conflict), and then ping me for review. Apologies for not reviewing this earlier.

JonathonMisiewicz avatar Dec 19 '24 14:12 JonathonMisiewicz

Rebase when #3256 is merged in (there will be a merge conflict), and then ping me for review. Apologies for not reviewing this earlier.

Hello @JonathonMisiewicz, since #3256 is now merged into master, I thought that I would notify you. This PR should likely be merged before my SAPT(DFT) External Potential #3257. Please let me know if there are any necessary changes or concerns. Thanks for your help!

Awallace3 avatar Mar 15 '25 22:03 Awallace3

Ping me for review when all checks pass. The current failures are due to this PR.

JonathonMisiewicz avatar May 20 '25 14:05 JonathonMisiewicz

Next commit make this change to fix the Eco (W) lane, https://github.com/psi4/psi4/pull/3302/files#diff-9886b1fe077112c3a9952964ed992dc3cd38b48d0a506a6b7a00241e4669d2b1R192 . Will watch the dftgrac error on Azure to see if it repeats.

loriab avatar Jun 01 '25 22:06 loriab