Lori A. Burns

By as-is on the definitions, you mean set when C found, @robertodr? Or potentially added three times if all langs enabled?

I'm going with ``` set(_omp_enabled_for_enabled_lang OFF) if(DEFINED CMAKE_C_COMPILER_ID) if(OPENMP_FOUND OR OpenMP_C_FOUND) set(_omp_enabled_for_enabled_lang ON) set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}") endif() endif() if(DEFINED CMAKE_CXX_COMPILER_ID) if(OPENMP_FOUND OR OpenMP_CXX_FOUND) set(_omp_enabled_for_enabled_lang ON) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}") endif() endif()...

Well, 7 lines where there used to be 1. But I don't see another dumb way around it (classifying your sol'ns as "smart" cmake uses).

Don't consider Psi4 as a an impediment to bumping min supported cmake version. For one, all the repos have their own copies of the autocmake file. For second, someday when...

FYI, cmake 3.11 (but not 3.9) gets around my initial problem by letting you specify a subset of the enabled langs to search for `find_package(OpenMP COMPONENTS C CXX)` and thus...

3.10 is the exact introduction date of the components mentioned above. fyi, libraries returned in the `OpenMP::OpenMP_CXX` target for `gcc` are `gomp;pthreads` and for `icpc` are `iomp5;pthreads`, along with corresponding...

I pinged you on psi4/psi4#1031 and would be glad of any comments on that new OpenMP-finding scheme. Most everything is centered in https://github.com/loriab/psi4/tree/openblas/external/common/lapack . The FindTargetOpenMP.cmake file within is most...

I meant to add last night that if you haven't already, please test with a mol with ghosts, dummy atoms, ecp's, away from std orientation, etc. (since you're handing over...

@davpoolechem , hooray approved! 1. do you want to fix the conflict and rebase so CI passes or do you want me to do it in the GH GUI? 2....

> I would indeed like to, yes. 👍 > The Psi4/GauXC interface supports using internally-built instances of GauXC. At first thought, we should be able to add it to Azure...