Ben Wolsieffer
Ben Wolsieffer
This is merged as part of #472
Foxy has been EOL for over a year. I didn't delete it as a courtesy to @hacker1024, but I'm not going to provide any fixes for it.
The certificate has expired again.
If there are upstream patches in recent distros that fix the problem, backporting them to humble is fine. I just want to things to start trending toward getting fixed upstream,...
I would also appreciate it if you could try to get newer distros working as well. In particular, the macOS dependency overrides probably be moved to `ros2-overlay.nix`.
Sorry, I didn't mean to make you add a bunch of hacks just to avoid making a custom version of the patch. I also didn't look at it closely enough...
It looks like both Iron and Jazzy have been upgraded to Ogre 1.12.10 and have https://github.com/ros2/rviz/commit/0ef2b56373b98b5536f0f817c11dc2b5549f391d applied. What is there to patch other than adding the macOS framework dependencies?
Also, LTS distros are way harder to support in this overlay because they lack all the fixes required to be compatible with newer dependency versions. nixpkgs keeps moving on, but...
You don't have to use `buildEnv`. It primarily exists because the environment variables can become too long with lots of ROS packages.
I can't reproduce any of this. That second issue was fixed a few weeks ago.