Vincent Lopes-Vicente comments

Results 8 comments of


                                            Vincent Lopes-Vicente

Version for php8

Yes and this PR #614 seems to say this is already compatible (not tested yet) just need to update composer requirements

Update Product.php

Hello, thank you for wanting to contribute to Thelia. Please, could you explain your pull request. What is the issue ? And when it happens ?

Improved the way the error message is passed to order failed page

There are still some bad case for `$order_id` in your PR

Order export fails when the shop has (not so) many orders

The exports as been rewamped since this issue, and I just did a test, I managed to export 80000 orders without problem

Add the ability to inject dependencies from the configuration files for commands, imports/exports, loops

This is done by the 2.5 and the symfony autowiring

A language cannot be deleted if it is referenced by an order

Same issue as #1145, the order table should not have any foreign keys on a table that does not belong to the order.

Keep the current page on language redirect

I look what you're saying before but this is not was happening in my case. If I go on "http://www.perceval-knives.co.uk/couteau-de-table.html" the domain is in english and the url in french,...

Keep the current page on language redirect

Ok but it's not really what I want so I think I will try to do my link differently. Thanks.