Luis Antonio Obis Aparicio
Luis Antonio Obis Aparicio
> > > > I am not sure if I follow. The early return is a dirty fix I made in order to avoid tests failing, I think it should...
Hello @juanangp, I also thought of this in the past, but after trying to refactor them to a structure like what you are suggesting I discovered why they are defined...
> Hi @lobis, > > I don't understand when you said that ROOT doesn't like to "put a vector inside a vector", this is what we are actually doing e.g....
Looking at the code it appears it's been this way for a long time now (I wasn't the one who modified it). I don't think it possible to set the...
LGTM but I will wait until the rebase is ready to properly review it. Thanks @Geogouz !
I vouch for this, I have personally used it in many repos and it's quite useful!
After doing an offline review with @bari12 , I will do some significant refactoring of the changes. I will mark it as ready again when done.
> > After doing an offline review with @bari12 , I will do some significant refactoring of the changes. I will mark it as ready again when done. > >...
> The new hard dependency on `opendata.rse_expression` breaks the backward compatibility but I am not sure how critical that is. You don't think of any problem there, right? It technically...
> The caching stores results for two hours but what about high-frequency dataset mutations or replica changes? Should any cache-invalidation be used here to avoid incorrect reported data during this...