Luis Antonio Obis Aparicio

Results 52 comments of Luis Antonio Obis Aparicio

It's interesting that the `clang-format` failed even after the PR bot made the formatting changes... 🤔

> @lobis it could also happen that the file was written back with an old ROOT version, the translation will be then already truncated inside `TGeoManager`, and even if it...

> I think we decided some time ago to move to C++17, I don't understand why we should revert to previous C++ versions, C++11 is from more than 10 years...

> The only line we shall follow is what ROOT is following. As long as ROOT could be compiled with C++11, we shall keep C++11 compatibility. That would be very...

> > We discussed this already with @lobis at some point. It is true this fact is missing. We discussed the idea about having another vector inside `TRestRawSignal`, for example...

> I agree with those statements, but not with the latest one. We should keep libraries independent one from each other, all inter-dependencies should be kept in `connectors lib`. There...

This is a great idea! I can do `geant4lib` and possible more, but first we should provide an example as you say. I am not sure if I understand the...

> I let @lobis decide about `detector-geometry` becoming a template. I would say no for the time being, its not very useful as a template at the moment since its...

> If returned, the global variables REST_COMMIT/REST_PATH/REST_USER are not set. It will make REST behave differently. I think we should set these variables manually before early return under testing condition....

> > I am not sure if I follow. The early return is a dirty fix I made in order to avoid tests failing, I think it should be possible...