Luis Antonio Obis Aparicio

Results 52 comments of Luis Antonio Obis Aparicio

> I think the short answer is: we should instead make sure that all backends support the full AbstractFileSystem interface, with upstream default implementations when appropriate. I would be surprised...

> I am confused, because AbstractFileSystem.cat_file does exist and has no NotImplemented in it. https://github.com/fsspec/filesystem_spec/blob/master/fsspec/spec.py#L752 ``` >>> fs.cat_file("tmp/file") Traceback (most recent call last): File "", line 1, in File "/Users/lobis/miniconda3/envs/uproot-38/lib/python3.8/site-packages/fsspec/asyn.py",...

> Now I'm more confused, because SFTPFileSystem is not async Sounds like a bug then, can you confirm you can reproduce this in your end? Otherwise I think I know...

> Thanks, I'm not sure about using all those formatters but clang-format as pre-commit hook is definitely a nice addition. I can simplify the list for now. Most come from...

> * can we even run the "build ubuntu/centos from source" workflows on github CI? don't they take too long? Yes you can, in my experience it can take ~...

> Given that the ubuntu22.04 image now comes with C++17, I am not sure there is still a strong motivation for having builds that do not use the default C++...

> Hi @lobis , thank you very much for your continuous help with this, much appreciated! > > As you see GitHub can't figure out how to rebase this branch...

> Yeah totally, I would play with this in my fork! GitHub is still unhappy: > > ![image](https://user-images.githubusercontent.com/10999034/169263490-09b4c22e-7731-46f8-91ef-ee5f15414c7d.png) I am not sure if I did it properly but what I...

> I see. It's likely the presence of that merge commit (master into feature branch) that confuses GitHub. Worst case scenario I'll fix this manually, do not spend too much...

> Hi, thank you for the suggestion, we'll look into it. Manpower on ROOT docker images is fairly limited, and I think the proper way to do this is to...