Logan Adams

Results 466 comments of Logan Adams

@k-artem - is this ready for final review? @hwchen2017 - any remaining review requests?

@SauceRaps - we haven't published a Windows wheel recently, but could you try to install the 0.16.5 version? https://pypi.org/project/deepspeed/0.16.5/#files

@shenzheyu - could you please resolve merge conflicts and then we can get this reviewed? Thanks!

Edit: this is no longer correct with latest changes. The current problem is that the logic inside setup.py aside from the call to `setup()` isn't run. This means that we...

@evencogitate - are you trying to use DeepSpeed on Windows then? We've not published new Windows wheels lately, and the Windows version is tied to the python and torch versions...

Hi @mauryaavinash95 - could you please run the pre-commit formatter? That should fix the formatting errors at least.

> Thanks for the feedback @loadams. I've fixed the pre-commit and DCO issues in [1c701d7](https://github.com/deepspeedai/DeepSpeed/pull/7166/commits/1c701d7c61b170eea81dcc637379500a7586b9b2). Thanks @mauryaavinash95 - The formatting checks look good, DCO shows failing. You can rebase to...

@mauryaavinash95 - is this ready to be merged?

@Ind1x1 - can you share your shared home memory size? Sometimes this can happen when it is set too low.