Logan Adams

Results 466 comments of Logan Adams

@hijkzzz - I haven't had time to work on this more unfortunately. @delock - @wenbinc-Bin's PR seems to maybe be the culprit, but could you help take a look too?

Hi @delock and @gyou2021 - what more needs to be done to complete this PR? Just a review/approval? Any other changes?

> Hi @loadams , is this PR under review? Thanks! Hi @delock - sorry for the delay in this, we will work on getting this reviewed.

@fengdian8564 - can you share the GPUs you are using (and the GPU memory) and the rough size of your model?

> Hi @NirSonnenschein, thank you for the great catch! Can you also add a small test case? We want to make sure that this change works for various settings. Hi...

> Hi @loadams , yes, sorry for the delay, I have been diverted to other urgent issues before completing the test. I should get back to this soon. No problem,...

@xqun3 - closing due to no reply, if you are able to, please try again with the latest DeepSpeed or share a full error log and I can investigate further..

@hipudding - anything to add here? Should we leave this open or close this?

@hipudding - let us know if we need to re-open this, otherwise closing for now since its not related to DeepSpeed