Louis Maddox
Louis Maddox
Thanks Ed! Yes I can help triage in prek repo :-)
Sorry Heinz, what do you mean? I outlined my approach [here](https://github.com/simd-lite/simd-json/issues/378#issuecomment-3394443027) as 2 steps, and you accepted the PR in value-trait with the first one, which this uses as its...
New type is now feature gated in but does not alter the existing one (the feature gate switch was an easier middle ground towards it though!) ### Testing feature compatibility...
> Sadly we're living in a time where I've to write reviews like this but I'm getting the strong feeling you're throwing an AI at this problem without thinking or...
Aha it's all good :sweat_smile: :pray:
The test needed a cfg(gate) but otherwise looks fine Merged on figment2 fork: - https://github.com/lmmx/figment2/pull/5
I've published a remaintained fork as [figment2](https://github.com/lmmx/figment2) to [crates.io](https://crates.io/crates/figment2), so far just updated the dependencies but happy to process PRs. If you want to avoid renaming the imports, you can...
Since this has gone uncommented on for a year, I supplied the details to ChatGPT o1 for any ideas or approaches, included below the fold Click to show This kind...