Louis Maddox

Results 158 comments of Louis Maddox

A little test that the URL is parsed as expected ```py @pytest.mark.parametrize( "gist_id,sha,file,token,user", [ ("my-gist-id-12345", "sha_hash_a0b1", "a_file.txt", "secret_token", "my-user"), ("my-gist-id-12345", "sha_hash_a0b1", "a_file.txt", "secret_token", ""), ("my-gist-id-12345", None, "a_file.txt", "secret_token", "my-user"), #...

Cool, all done. A "round trip" might be nice too

Checks passed, 3.10 failed with an intermitten HTTP error from conda repodata (I don't have the ability to re-run it), LGTM

[Coin CBC](https://github.com/coin-or/Cbc/blob/b5a21d4ae045513f0a8b3de21d6df18917ed1ddb/src/CbcBranchAllDifferent.cpp#L27) supports this, as does Pumpkin (#95)

Calling it a night now, looks like I need to add back some test coverage (I have the test cases for these in the examples of [this repo](https://github.com/lmmx/fp-len-validation-testing/tree/master/examples) so will...

@sydney-runkle no, not ready: I just need to write unit tests (note the reduced coverage), this is next up! Getting late here so it'll be tomorrow :sleeping_bed: :zzz: I spent...

> @lmmx, > > Is this ready for review? Picking up where we left off... I prepared examples ([here](https://github.com/lmmx/fp-len-validation-testing/tree/master/examples)) and put simple unit tests on them like this: ```py def...

Looks like it's failing on Windows and macOS On macOS the failure is only in the test where a Path and filename is created with both parts `{dir_name} / `{file_name}`...

Think this was a misunderstanding—Keith was saying to pass `-l json`, not `-l jsonl` (which errors as shown in the issue description). > But in case of a pipe, the...

This bug has also been noted [here](https://stackoverflow.com/a/73900607)