Louis Maddox

Results 158 comments of Louis Maddox

Looking at htop (F4: filter `bat|less` then run `echo | BAT_PAGER='less -R' ./target/debug/bat`) I can see this patch is qualitatively different: with the existing `bat` ## Existing ``` PID USER...

OK, I've marked #3447 as ready for review in that case, if that's an acceptable solution to this then it is a working option.

Okie doke, I'll leave this open then (or feel free to close if you have other tracking for 3.15t)

I think maybe it'd help to suggest the actual values that we would put in those as an example of use To give an example myself, I could achieve behaviour...

The panic occurs in the Drop implementation for OutputType in src/output.rs. The problematic code is: https://github.com/sharkdp/bat/blob/4e13c3eb5bd5e78de8cafb4b21f646b880216c2d/src/output.rs#L210-L214 char 65 would be the final `.unwrap` https://github.com/sharkdp/bat/blob/4e13c3eb5bd5e78de8cafb4b21f646b880216c2d/src/output.rs#L19 - The first one is safe...

Cannot repro this namely as my `alias` doesn't have a `-g` flag @imsakg can you repro with any other style of calling it, e.g. by setting `BAT_PAGER='builtin'` before the call...

Re-pushed to ensure tests pass incrementally - All tests passing on new base commit ce43cde

Re-pushed to reorder commits (protocol may need to be split off if it's the one causing test failures) There are far fewer test failures on the (now 2nd) commit, the...

I've rolled this into #313 but happy to break it out into a focused PR if preferable to review/merge separately. - **fix: move missing_values++ to after create mode early return**...

I tried building a crate depending on this branch and it stopped due to an error that may be unrelated ```rust evaluation panicked: Your generated code is out of date,...