Luis Michaelis

Results 106 comments of Luis Michaelis

> There is a Ikarus/LeGo ticket https://github.com/Try/OpenGothic/issues/231 - basically we need a way to override user-defined script functions (to trap MEM_Write*) and some way to handle out-of-bounds access. Something, like...

> phoenix uses at least one C++20 feature, std::span. This leads to phoenix not properly compiling with C++17 (which you are using). A solution would be to update to C++20....

> Basically I'm lazy on doing followup work to C++ version bump (like rewriting stuff, like (T*,size) to std::span :D Well you don't _have_ to change that .. It's not...

> Can you double check it please? If there are compiler issues with C++20 std library, that can be a blocker. Otherwise - can't wait to drop std:snprintf's :D Hm...

Heyo @Try, I've opened a PR since I'm done moving everything except the VM over to _phoenix_. I need help to weed out some bugs though (see the PR). I'm...

Oh, I'm sorry [this](https://github.com/Try/OpenGothic/blob/5485f843216f6129d196addc1650b8fd2b5c1ad8/game/game/gamescript.cpp#L949) is the correct link. Then I believe we're dealing with two bugs here. First the bug in the script itself and second another bug in the...

> Can it be handled by something like, exception throwing? Yes, that is how it is handled right now. I am concerned about performance using exceptions, however since this kind...

Ah, sorry, I forgot to include more information. I've updated with screenshots and recording to explain the problem. I've also added the commit I first noticed this to make troubleshooting...

Okay @Try, I've managed to fix most of the bugs :tada: I can't seem to find the cause of the broken fight animations though. Could you take a look at...

Hi there, just checking in since I have been working very slowly over the past few months. I am still working on this and I just had a breakthrough migrating...