Luis Michaelis

Results 106 comments of Luis Michaelis

> This causes nullptr chaos and part of code, that use to work now cause crashes. It would be nice to guarantee, those pointer to be non-null. Without non-null game...

> Can you provide a dummy visual, and point to it? I could, though I would lock it behind a compile-time setting if that's okay with you. > Side topic:...

> Can you provide a dummy visual, and point to it? Done in 18318ec. Please confirm @Try. Are there any other concerns with the new version? If not, I'll finally...

True, I forgot about that :D Updated in 35938c2.

> Scripts compiled by vanilla compiler may have inconsistent sequence of push/pop, leaving more data in stack, that expected by caller Proposal: improve guard-related code in opcode::bl Can you point...

> Tested vanilla G2-notr, via: Yes I know these cases exist, but where does extra data on the stack cause actual problems? Just so I can properly understand why this...

Oh, thank you! I am now able to reproduce the errors! Looks like I just had to update my packages. I was about to say that this does not make...

Hi, thanks I'll look at it. I might just implement a proper parsing routine if I can find documentation :)

@Try I've added the exception as requested. You can now catch `phoenix::vdfs_signature_error` for this specific error. Could you send over the VDF file that caused the error so I can...

I see. I'd still like to implement it so I'll keep this issue open :>