Louis Korczowski

Results 17 comments of Louis Korczowski

Thanks @nik-sm , I've updated the requirements. However I'm keeping this issue open because of the `libncurses5-dev` dependency. @mesca is it normal ? Should we add the instruction in timeflux/README.md...

@lokinou if you installed a clean conda environment, it should work fine. `pip install -e .` shouldn't be required for now. Thanks for noticing and yes, there should be a...

the only time ```data(:,subrange) = bsxfun(@times,blend,R*data(:,subrange)) + bsxfun(@times,1-blend,state.last_R*data(:,subrange));``` is actually doing something is at the beginning of the loop, that's all (```j=1```). And I still don't understand why :/

Not as important, but still... ``` % use eigenvalues in descending order [D, order] = sort(reshape(diag(D),1,C)); ``` is actually in ascending order... (a lot of weird stuff are everywhere like...

Decision required here: @bertrandlalo @sylvchev @mesca - Should we implement this ? - If yes, should it be in transform() or in another function like "adapative_transform()" as the reconstruction matrix...

As I understand it, the code ``` blend = (1-cos(pi*(1:(n-last_n))/(n-last_n)))/2; data(:,subrange) = bsxfun(@times,blend,R*data(:,subrange)) + bsxfun(@times,1-blend,state.last_R*data(:,subrange)); ``` makes an interpolation between the reconstruction of the data with the current reconstruction matrix...

OK, I'll implement the blending with a condition if the reconstruction matrix changed. I'm closing this issue when implemented

Noted: - it will be an option during the initialization (sklearn doesn't like additional criterion) - default behaviour will be without blending (sklearn learn friendly and required behaviour during standard...

Comment: Due to current behaviour in Timeflux, each epoch = 1 reconstruction matrix. In the case of sliding windows for epoching, several epochs may have same timestamp but different resulting...

Example of transition _without(left) or with(right) blending. top: input signal. bottom: blended signal. Alternating between two reconstruction matrices (identity and [-1,1;1,1])_ Pro of blending: - no discontinuity - smooth Con...