BCI-2021-Riemannian-Geometry-workshop icon indicating copy to clipboard operation
BCI-2021-Riemannian-Geometry-workshop copied to clipboard
verified publisher icon lkorczowski

requirements file error for timeflux demo

Open nik-sm opened this issue 4 years ago • 2 comments

There's a small typo on https://github.com/lkorczowski/BCI-2021-Riemannian-Geometry-workshop/blob/f30b67a007d612735e44f935cea07848cc59c00d/timeflux/requirements.txt#L7

git+https://github.com/pyRiemann/pyRiemann#egg=pyriemman should be git+https://github.com/pyRiemann/pyRiemann#egg=pyriemann

I also had to sudo apt install libncurses5-dev, otherwise I got an error during "Building wheel for gnureadline"

nik-sm avatar Jun 23 '21 17:06 nik-sm

Thanks @nik-sm , I've updated the requirements. However I'm keeping this issue open because of the libncurses5-dev dependency.

@mesca is it normal ? Should we add the instruction in timeflux/README.md ?

lkorczowski avatar Jul 15 '21 16:07 lkorczowski

Hi @nik-sm, good catch! When we published the demo, we needed the dev version of PyRiemann, but since then, a new PyPy package has been released that includes our fixes. In 941c1821deaceeb38dfe86fc20ba6536e294a8df, I have updated the requirements to use version 0.2.7. Does it solve your libncurses issue?

mesca avatar Jul 15 '21 16:07 mesca