carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Change chevron icon to caret icon - FlatTable component

Open ibsenjg opened this issue 2 years ago • 6 comments

Desired behaviour

Hello, I want to choose the variant for IconType in Expandable Flat Table as you do for Accordion to use the "Caret" icon instead "Chevron" for all expandable elements within the table.

Current behaviour

the Icon’s type is hardcoded as chevron_down_thick when using the expandable rows functionality

Suggested Solution

Could we extend or create a new property for FlatTable to change this IconType variant?

CodeSandbox or Storybook URL

https://codesandbox.io/s/serene-sara-5rtfmj

Anything else we should know?

No response

Confidentiality

  • [X] I confirm there is no confidential or commercially sensitive information included.

ibsenjg avatar Aug 11 '22 14:08 ibsenjg

@ljemmo would you mind take a look at this and saying whether it's something we should support please?

edleeks87 avatar Aug 16 '22 12:08 edleeks87

@edleeks87 for me to comment, i'd have to see the design to understand why this was requested. Ideally we'd want to keep this component as simple as possible and include a minimum variety of icons.

@ibsenjg please can you share the design spec that prompted this request?

ljemmo avatar Aug 16 '22 16:08 ljemmo

Hello @ljemmo @edleeks87 this is a feature request from @danielr-sage to use caret instead chevrons for Report Table. Can i paste Figma designs here?

ibsenjg avatar Aug 18 '22 08:08 ibsenjg

@ibsenjg please don't post the designs here. If @danielr-sage reaches out to Luke on slack or teams he can review the request and designs there

edleeks87 avatar Aug 18 '22 08:08 edleeks87

Hi @danielr-sage @ljemmo, was a decision made regarding this request? 😄

Parsium avatar Aug 30 '22 14:08 Parsium

@Parsium Not yet. I'm working to present this together with other related updates to the design system team. It may take a few weeks. If you prefer, we can close this ticket and open a new one once it's investigated properly approved. Thanks

danielr-sage avatar Aug 31 '22 07:08 danielr-sage

Upon discussion with @danielr-sage, this has been proposed to the Design System team for consideration. @ibsenjg in case this is blocking your work please could you feed this back to your designer? I would recommend sticking with the chevron icons for now until we receive confirmation from the Design System team whether they would to introduce this or not.

Parsium avatar Oct 04 '22 14:10 Parsium