Lizan Zhou comments

Results 42 comments of


                                            Lizan Zhou

Add support for intermediate CA as trusted_ca

1. sounds reasonable to me.

TLS bumping: decrypting communications between internal and external services

> 1. Where to generate certs? > After deliberation, I think `tls_inspector` is not a good place for generating certs, because we don't want dynamically generating certs for all SNI,...

oauth2: add "default_expires_in" config option

/lgtm api can you check CI failures?

access logging: gRPC logger improvements for Envoy as TLS transparent proxy

The implementation makes sense. Can you check CI, and also add tests for those logging field that you added?

access logging: gRPC logger improvements for Envoy as TLS transparent proxy

@niektemme add an entry to https://github.com/envoyproxy/envoy/blob/main/changelogs/current.yaml

access logging: gRPC logger improvements for Envoy as TLS transparent proxy

@niektemme sorry I was off for a week for medical reasons and now back. Can you merge main to resolve conflicts? Otherwise it looks great.

access logging: gRPC logger improvements for Envoy as TLS transparent proxy

@niektemme you can merge main branch to your PR branch and resolve conflicts, then push that change to your PR branch.

Create Compatibility Matrix

Let's use `envoyproxy/proxy:v1.23.1`, or `envoyproxy/proxy:v1.23-latest`.

introduce `HeaderValue` type to replace use of `String`

@PiotrSikora PTAL. While it's not encouraged but we do have certain traffic contains non UTF-8 header value. Since spec allows it historically, we shouldn't block that. > Historically, HTTP has...

The [converter::ErrorListener](https://github.com/protocolbuffers/protobuf/blob/v3.7.0/src/google/protobuf/util/internal/error_listener.h#L53) is for this purpose, though it is in internal header so ideally we want to make it as a part of public API.