Lizan Zhou comments

Results 42 comments of


                                            Lizan Zhou

Dynamic Metadata match not working unless I modify headers via Lua script

This is a non well-documented behavior, Envoy caches the route decision before the request hit filters, and the JWT filter doesn't clear the cache. The Lua filter when it is...

Configurable Envoy Access Logging

@danehans that is only for the admin endpoint, the other logs is configured via xDS component.

xds: Adds extension points to receive config update notifications

Defer to @adisuissa for final merge.

subset_lb: add metadata_fallback_policy

/lgtm api

tls/validation_context_sds_secret_config does not work with ADS

Thanks for reporting. This sounds like a bug from the initialization order because when the static cluster initializes the ADS subscription doesn't exist yet.

fix clang-tidy reported errors on master

@zyfjeff Great, I think you can just run clang-tidy with `-fix` flag with the checks marked as error.

fix clang-tidy reported errors on master

@auni53 Definitely, do you want to take that part?

fix clang-tidy reported errors on master

@auni53 'ci/run_clang_tidy.sh' is written for running from do_ci.sh so it may depend on env vars from there. Usually I do `tools/gen_compilation_database.py --run_bazel_build --include_header && run-clang-tidy-7`, let me know (or ping...

fix clang-tidy reported errors on master

@auni53 no `run-clang-tidy-7` (without space) is the right one if you're in envoy-build-docker or have llvm installed via official apt repository.

Add support for intermediate CA as trusted_ca

Yeah this sounds good to me, as a quick review, please add release note as behavior change.