envoy icon indicating copy to clipboard operation
envoy copied to clipboard

oauth2: add "default_expires_in" config option

Open riptl opened this issue 3 years ago • 5 comments

Signed-off-by: Richard Patel [email protected]

Commit Message: oauth2: add "default_expires_in" config option Additional Description: Fixes compatibility with OAuth 2.0 authorization servers that don't provide the "expires_in" property in the token response Risk Level: Low Testing: Added OAuth client tests for two new branches (default expires_in, missing default or explicit expires_in) Docs Changes: Inline API proto Release Notes: oauth2 filter: added "default_expires_in" property for authorization servers that don't provide the "expires_in" token response property Fixes https://github.com/envoyproxy/envoy/pull/14254 Continuation of #14625

riptl avatar Jul 06 '22 01:07 riptl

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/). envoyproxy/api-shepherds assignee is @htuch CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

:cat:

Caused by: https://github.com/envoyproxy/envoy/pull/22029 was opened by terorie.

see: more, trace.

Re-assigning API review to @lizan as I'm out.

htuch avatar Jul 07 '22 05:07 htuch

/lgtm api

can you check CI failures?

lizan avatar Jul 07 '22 06:07 lizan

Still waiting on CI errors fix. /wait

adisuissa avatar Jul 12 '22 14:07 adisuissa

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Aug 11 '22 16:08 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Aug 18 '22 16:08 github-actions[bot]