Karol Bieniaszewski

Results 150 comments of Karol Bieniaszewski

> Please understand that I cannot accept such a pull request just because it compiles. I know but it do not only compiles, it does not break the current VCL...

> But why do these changes need to be in the master branch? I do not suppose that dividing this by new branch do something useful. I am opposite, this...

The longer this code will be in a separate branch, the more difficult it will be to merge, because it will be more and more forked. However, merging this now...

I am not totally opposite to have new branch. It have some benefits. But, what make this new branch better approach? If now we have code working on VCL and...

> I will always seek for the cleanest solution. I too. I only do not know what are the preferences here. For example i see now that creating new unit...

Ok, i have made changes. - changed all to TDimension - except events - changed HDC to TCanvas - sometimes this require dummy canvas but no overhead as i create...

> Sorry, but these changes have been done in your branch. If I accept the PR now, I will get all the changes including all incomplete FMX stuff. As I...

I have added other commits releated to paintings.

I have added initialization of system checkboxes and radio buttons, Added also Android support. Tested on Samsung A5 Android 8.0 and it is working :)

Do you think that merging is possible in near feature? Because merge new changes from master is too costly and error prone.