Karol Bieniaszewski

Results 150 comments of Karol Bieniaszewski

I shortened the answer ;-) On VCL pattern is a bit mask, color is applied leter. On FMX it work with color included. So two brushes needed, but they are...

Currently there are two members for VCL too, but as on VCL it is not needed it simple have getter from second. https://github.com/JAM-Software/Virtual-TreeView/pull/1135/files#diff-7043477841360f7ac0a14b63b865317b48576c9d94e978c21205a3aea0dda736 ``` property DottedBrushTreeLines: TBrush read FDottedBrushTreeLines write...

Look at `DrawDottedVLine`, there is `Canvas.Brush.Color` change But to `Winapi.Windows.FillRect` `DC` of `Canvas` is passed and separately `dottedBrush.Handle`. Without changing the brush color itself, there is a draw of `dottedBrush`...

@joachimmarder I do not looked at your current changes, but look at discussion why it was introduced as two classes not one: https://github.com/JAM-Software/Virtual-TreeView/pull/1125#issuecomment-1264352309 >How is your progress in the FMX...

I need to incorporate all your changes since the last time I ran this code. And in the meantime, I see a lot has happened. When I'm done, I'll try...

Finally done "merge" and fixes. Pull request created. Now i am ready to move forward. Some of your changes fixes some problems. And extraction of code to e.g. VirtualTrees.Types was...

> Well, the quesion remains if `TVTAncestorVcl` is truly necessary. I was able to move a lot from here to `TVTBaseAncestorVcl`. Until we finish full FMX port i cannot decide....

In the `VirtualTrees.pas` there is `InitializeGlobalStructures` but nowhere called? Is something broken?

But this is different (different code) `InitializeGlobalStructures` located in `VirtualTrees.BaseTree.pas` but `InitializeGlobalStructures` from `VirtualTrees.pas` is not used.

From my side no.