Jacky Lau

Results 56 comments of Jacky Lau

and do you have time to review this https://github.com/apache/flink/pull/20544 and https://github.com/apache/flink/pull/20546 ? and the ci is not green because of kafka end to end test, which is not relate to...

> does it make sense in that case to support only dates without seconds/minutes/hours? yeap.

hi @twalthr @wuchong do you have time to review it?

hi @snuyanzin could you help review it?

hi @xuyangzhong @lsyldliu i have add comments for important part, it will be convenient for review. will you have time to help review?

> Thanks for driving this. I left some comments. BTW, what about attaching the difference about the codegen result before and after this pr? What's more, should we remove the...

hi @hanyuzheng7 @dawidwys , i submit pr before, why submit another pr? https://github.com/apache/flink/pull/22629 https://github.com/apache/flink/pull/23959

@dawidwys great plan +1. because my prs do not have people to review. will you have time to help review them?