flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

Open snuyanzin opened this issue 3 years ago • 2 comments

What is the purpose of the change

This is an implementation of ARRAY_APPEND and ARRAY_PREPEND inspired by https://github.com/apache/flink/pull/19543

Brief change log

  • ARRAY_APPEND for Table API and SQL
  • ARRAY_PREPEND for Table API and SQL

Verifying this change

This change added tests in CollectionFunctionsITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes )
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

snuyanzin avatar Jun 03 '22 09:06 snuyanzin

CI report:

  • f638db8116a5dc87489e640891366b8c09252f00 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jun 03 '22 09:06 flinkbot

@flinkbot run azure

snuyanzin avatar Jun 03 '22 13:06 snuyanzin

yes i will

snuyanzin avatar Mar 29 '23 20:03 snuyanzin

rebased to fix conflicts

snuyanzin avatar Mar 30 '23 12:03 snuyanzin

rebased since there were several build failure fixes in master

snuyanzin avatar May 22 '23 17:05 snuyanzin

@flinkbot run azure

snuyanzin avatar Jun 18 '23 07:06 snuyanzin

@snuyanzin thanks for your pr, LGTM

liuyongvs avatar Jun 26 '23 11:06 liuyongvs

@snuyanzin Are you still working on finalizing this PR?

MartijnVisser avatar Jan 26 '24 12:01 MartijnVisser

ah.. sorry completely forgot abou it yeah, I'm going to fix the conflicts and merge after build is green

snuyanzin avatar Jan 26 '24 14:01 snuyanzin

@MartijnVisser since there is a feature freeze do you think it makes sense to add it in 1.19?

Otherwise I'm going to add it when a new release starts

snuyanzin avatar Jan 30 '24 00:01 snuyanzin

Let's add it for 1.20, and honor the feature freeze

MartijnVisser avatar Jan 30 '24 18:01 MartijnVisser

rebased to resolve conflicts

snuyanzin avatar Feb 12 '24 22:02 snuyanzin