flink
flink copied to clipboard
[FLINK-33951][table] Use aggCallNeedRetractions instead of needRetrac…
What is the purpose of the change
- should use aggCallNeedRetractions instead of needRetraction to check retract method, orelse throw not implement retract method*
Brief change log
- should use aggCallNeedRetractions instead of needRetraction to check retract method, orelse throw not implement retract method*
Verifying this change
- original unit test *
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
@Public(Evolving): (no) - The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
Documentation
- Does this pull request introduce a new feature? (no)
CI report:
- b28811b092f713f68a1fe5834b84cdb00805f87f Azure: FAILURE
Bot commands
The @flinkbot bot supports the following commands:@flinkbot run azurere-run the last Azure build
hi @xuyangzhong @lsyldliu i have add comments for important part, it will be convenient for review. will you have time to help review?
Thanks for driving this. I left some comments. BTW, what about attaching the difference about the codegen result before and after this pr? What's more, should we remove the hack logic in function
retractExpressionsinMaxAggFunctionandMinAggFunction?
when using the imperative agg, we should remove it. but we can not remove it in declarative agg, because all the declarative agg should override the method. so we can remove it when we upgrade it from declarative to imperative.