Thomas Li

Results 199 comments of Thomas Li
trafficstars

> Sure by all means. FWIW I've been trying to keep the order of cherry picked commits maintained and put any custom patches at the end Ah cool. I'll first...

(tagging build so we get some CI signal from the wheel builders as well)

I can't reproduce but, If this happens utcoffset should be returning None at this line https://github.com/pandas-dev/pandas/blob/bdb509f95a8c0ff16530cedb01c2efc822c0d314/pandas/_libs/tslib.pyx#L527 cc @MarcoGorelli

This diff fixes it for me, not sure why though. Maybe it's an ipython bug? (opt is ``cf.option_context("display.html.table_schema", True)``) ``` diff --git a/pandas/tests/io/formats/test_ipython_compat.py b/pandas/tests/io/formats/test_ipython_compat.py index 8512f41396..67bb0fb9e3 100644 --- a/pandas/tests/io/formats/test_ipython_compat.py +++...

I don't remember the context behind this anymore, sorry. Feel free to open up a PR for more discussion.

No, I don't think this should be backported, 2.1.0 seems fine to me (its gonna come out around in a month or so).

I _think_ this fixes the failures, so going to merge on red. thanks @bnavigator