Zhang Zhuo

Results 69 comments of Zhang Zhuo
trafficstars

agree with @z2trillion . seems don't need to add committed_value to Rw::Account since evm circuit does not need that.

btw in the original zcash/halo2, only fixed columns are allowed to be lookup table. So there are no this type of problem in their circuits.

do you think end_block can handle this? or this is indeed a problem? @ed255

> Another alternative solution is that we include the selector column in the lookup argument such that we only look up into the rows with the selector set to 1....

The lookup is indeed incorrect. In fact these tests are deliberately constructed to be negative tests to check error is indeed error

another issue is to check whether it is possible to fetch 256 block hashes using one graphQL rather than 256 normal rpcs..

https://github.com/scroll-tech/halo2/pull/14 sonething like this?