Zhang Zhuo

After some discussion we choose to let non-existing proofs be a TODO (future PR). @silathdiir Anyway 1 day dev time does not mean 1 day diff in wall clock delivery...

Haha in fact wa have already made a binary posedion storage tree https://github.com/scroll-tech/mpt-circuit/blob/master/spec/mpt-proof.md

@NoCtrlZ i posted some cpu profiling graph here. . It seems `Domain::rotate_extended` costs lots of time. Maybe another big issue we need to solve later.

upstream halo2 introduced AST for ploy and performance get improved. (details : ) We may need to merge the upstream later.

println should not be replaced by log in build.rs? https://doc.rust-lang.org/cargo/reference/build-scripts.html

need to modify https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/3da1888cfdea1f05062477279d9c5088e01fac19/zkevm-circuits/src/witness/step.rs#L184

@ed255 fixed bytecode table but not keccak table. Explained above

@DoHoonKim8 oh there is one thing missing.. After https://github.com/privacy-scaling-explorations/zkevm-circuits/pull/1020, we should no longer write `let code_hash = block.rws[step.rw_indices[8]] .table_assignment_aux(block.randomness) .value;`, it should be changed like `self.code_hash .assign(region, offset, region.word_rlc(code_hash))?;` ....

another problem is the non exist proof refactor like this https://github.com/privacy-scaling-explorations/zkevm-circuits/commit/aaaf13ee3020661e048484776bd88686d1659042. @ed255

oh i enabled RUST_LOG=trace for this gadget, can i believe ErrorOutOfGasEXTCODECOPY is triggered.. The extcodecopy gadget may not be tested at all.. @DoHoonKim8