Zhang Zhuo

Results 69 comments of Zhang Zhuo
trafficstars

public data: orderbook / tick(every trades) private data: my orders

WIP Step1: add POST 'restapi/order' endpoint in 'src/bin/restapi' The following request will be processed by . ( See for deployment details) . ``` curl 'http://18.180.248.43:50052/api/order' \ -H 'Connection: keep-alive' \...

in restapi or matchengine? Do we need to add this feature in our first demo version?

APIs of the gateway: here is an example of APIs ( ccxt / freqtrade) : https://github.com/freqtrade/freqtrade/blob/develop/freqtrade/exchange/exchange.py

oh btw i can upstream better bus-mapping handling of self-destruct. It helps build correct statedb. Soon. https://github.com/scroll-tech/zkevm-circuits/blob/2723b82fb5d538d6fcc7b2dd0d84d3df8818499f/bus-mapping/src/evm/opcodes.rs#L499. it is battle tested with mainnet.

btw i think the collision test is not enabled in fact... this should be true.. https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/4f1f56e41e8b1a724ae141a5e7b27d2e19c07353/zkevm-circuits/src/evm_circuit/execution/create.rs#L888

another remainder is that we need to support prevrandao opcode (renamed from DIFFICULTY). I make this change https://github.com/scroll-tech/zkevm-circuits/blob/1ea9b5970ff873191de29e625687765f427326dd/bus-mapping/src/circuit_input_builder/block.rs#L119-L127 to be compatible with latest node/libs.

btw i noticed this line may not be correct? https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/1691c53e68754279ae2654747a4c47f78a9eeb34/bus-mapping/src/evm/opcodes.rs#L601 ``` coinbase_balance_prev + effective_tip * (state.tx.gas - exec_step.gas_left.0 - effective_refund); ```

We have this partially implemented. The evm circuit can support 1559 related mechanism (like fee burn) and rlp circuit/tx circuit can accept 1559 txs(but may not fully sound now). But...

Similar But not same. If the deployment address has eth but not contract then it is not err