Lishid

Results 93 comments of Lishid

https://github.com/der-tobi/obsidian-simple-mention/blob/5ca64587aae6d14f17d6a2e628fc16c8164e1c69/src/main.ts#L55 See tip at: https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md#avoid-managing-references-to-custom-views https://github.com/der-tobi/obsidian-simple-mention/blob/5ca64587aae6d14f17d6a2e628fc16c8164e1c69/src/main.ts#L56 Memory leak here - your view isn't unsubscribed from the event when the view is disposed (view.onunload). https://github.com/der-tobi/obsidian-simple-mention/blob/5ca64587aae6d14f17d6a2e628fc16c8164e1c69/src/PreviewStyle.ts#L21 Should cache this regex rather then...

https://github.com/branwall/obsidian-reset-checkboxes/blob/f3a10dd1f7dc4b8442dba2cd6e5a66230a7faca5/main.ts#L13 Ok here I would suggest running your code on a line-by-line basis instead of using `getValue()` because when you replace the whole file's content with `setValue()`, it causes line...

https://github.com/Die4passion/obsidian-daily-todo-pro/blob/19a25755232d2860fdea356549d582491a4fea2c/src/index.js#L38 Should rename the class name. https://github.com/Die4passion/obsidian-daily-todo-pro/blob/19a25755232d2860fdea356549d582491a4fea2c/src/index.js#L94 Should import `moment` from `obsidian` https://github.com/Die4passion/obsidian-daily-todo-pro/blob/19a25755232d2860fdea356549d582491a4fea2c/src/index.js#L99 Should use `getAllMarkdownFiles` instead. https://github.com/Die4passion/obsidian-daily-todo-pro/blob/19a25755232d2860fdea356549d582491a4fea2c/src/index.js#L115 This could be fairly expensive when you keep parsing the file dates....

https://github.com/Die4passion/obsidian-daily-todo-pro/blob/2dfecadae0e61168312c33fce7b4cb210c8c5f55/src/index.js#L65 I don't think this is a great way - you're defining an array but using really high numbers for indices which usually is inefficient depending on the engine. You...

I believe the new `MarkdownRenderer.render()` supports this, assuming you properly manage the lifecycle of the `Component` being passed in (make sure it's loaded going in, and then unload it when...

The English dictionary works perfectly fine if there is not another language set: ![image](https://github.com/electron/electron/assets/609710/3171ef46-67f9-4d65-9334-f72742de2b6a) ![image](https://github.com/electron/electron/assets/609710/eb0efea3-0f10-40e6-9afe-f85f8725f3f7)

Here are more cases: With `['en-US', 'de']`: ![image](https://github.com/electron/electron/assets/609710/80fa4553-d9bf-491c-b000-397d095e27be) With `['de', 'en']`: ![image](https://github.com/electron/electron/assets/609710/b578e90f-11d0-478e-a820-80faa4a0c17e)

For Obsidian Sync, any non-recognized folders in `.obsidian` are ignored. The setting for syncing 3rd party plugins will sync files in the folders `.obsidian/plugins/plugin-name`, so this is why 1. You...

If you're interested, I suggest possibly a way to pack and unpack through zips using [this zip library](https://www.npmjs.com/package/@zip.js/zip.js). It will unfortunately bloat up your plugin's minified size by a few...

Yeah.... so we went back and forth on this in the beginning. You can use it with no problem, and we will not remove it for the foreseeable future. The...