Lishid
Lishid
Sending back some code review feedback from another plugin: > Don't keep a reference to your view, as you might have a reference to an outdated/detached view. Instead, use workspace.getLeavesOfType(MY_VIEW_TYPE)...
https://github.com/esm7/obsidian-vimrc-support/blob/8ab389c73e98d5ff82d850656d4150a1ba4fb63c/main.ts#L79 Here you are reading and re-parsing the vimrc file whenever the user opens a file, or switches pane. Maybe there's a better way so it doesn't get loaded as...
### Preflight Checklist - [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project. - [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to. -...
### Preflight Checklist - [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project. - [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to. -...