Lishid

Yeah, I can give it a go. EDIT: Might take some time before I can get to it but I will once I'm migrated over.

I've taken a look at the plugin code and unfortunately I think it would require a lot of changes to be in a state that I'd feel comfortable merging into...

https://github.com/amykhar/obsidian-day-planner-with-templates/blob/07b797d3b5006cb84a9fc60a2fe57dd9a979d826/src/main.ts#L100 I know this is similar in the original day planner but I highly recommend against re-reading the day planner file from disk every 2 seconds and do a full...

> But I think point 3 with Vault.adapter is wrong, because that's possible. I meant using FileSystemAdapter, and associated internals like basePath, etc. --- I have a workaround for the...

Any updates on this PR? Do you still intend to add it to the plugin repo?

https://github.com/farux/obsidian-text-toolbar/blob/833e17d45a9b88c9e41e103f5a1990d4f53c543f/utils/ToolBarBuilder.ts#L6 This shouldn't inherit Plugin. https://github.com/farux/obsidian-text-toolbar/blob/833e17d45a9b88c9e41e103f5a1990d4f53c543f/utils/Action.ts#L5 Same here, and probably for all your other classes - you should only have a single class extending `Plugin` in your entire bundle. https://github.com/farux/obsidian-text-toolbar/blob/833e17d45a9b88c9e41e103f5a1990d4f53c543f/utils/ToolBarBuilder.ts#L25...

https://github.com/hadynz/obsidian-sidekick/blob/4f61555a7268d8806aeb35e23a869311102fae44/src/index.ts#L23 See this new tip for a better way to manage cm6 extensions: https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md#how-to-changereconfigure-your-cm6-extensions https://github.com/hadynz/obsidian-sidekick/blob/4f61555a7268d8806aeb35e23a869311102fae44/src/indexing/indexer.ts#L13 You are leaking this event registration which is not un-registered when your plugin is disabled....

Any updates on this PR? Do you still intend to add it to the plugin repo?

Ok we can leave this open since you're still working on it.

That's such a great bug report!