Eli
Eli
> ```jsonc > "skipNodeModulesBundle": true, // You can try changing this, but I found bundling to bundle `node_modules` too, which isn't what we want > "minify": true, // I can...
> `skipNodeModulesBundle` and `removeNodeProtocol` aren't documented anywhere and i really don't feel comfortable using undocumented behaviors unless there is a critical need. - `removeNodeProtocol`, fair enough. - `skipNodeModulesBundle`, I'm going...
I also discovered that the CJS build is broken by default, we need to enable `cjsInterop` (which requires `splitting`) 😢. Otherwise, it emits the wrong CJS types. See: egoist/tsup#572, egoist/tsup#992,...
> But in the [docs](https://tsup.egoist.dev/#excluding-all-packages) it says: > > > tsup automatically excludes packages specified in the dependencies and peerDependencies fields in the package.json Correct. I think it's a bug....
> I just built `eslint-config-sheriff` locally (from `master`). It produces a `index.js`, a `index.d.ts` and a `index.cjs`. It's missing an `index.d.cts`, which is fixed on this branch _except_ that is...
That was the goal, to get ~~attw~~publint passing. Currently, (almost) all sheriff packages are masquerading as ESM, this separates the files, but ESBuild currently still outputs ESM syntax in CJS...
Just if you're curious, this is a good read: https://blog.isquaredsoftware.com/2023/08/esm-modernization-lessons/ I just refound it, and it was quite useful. P.S: I'm still working on this :)
> I'm really looking forward to merge all your open PRs, sorry for the conflicts >_< It's fine :) > I'm especially looking forward the "turbo watch" enablement. I think...
> Makes sense, would you be interested in working on that issue? Interested, yes; actually do it, probably someday? 😁 ~~Now that I think about it, it'd probably be a...
Huh. Can't repro the formatting issue on master.