Eli

Results 430 comments of Eli

> Should be good to merge (SemVer minor), but we probably ought to wait until CI's fixed (https://github.com/jfmengels/node-elm-review/issues/176#issuecomment-2325358713). _Originally posted by @lishaduck in https://github.com/jfmengels/node-elm-review/issues/241#issuecomment-2325412236_

> Should be good to merge (SemVer minor), but we probably ought to wait until CI's fixed (https://github.com/jfmengels/node-elm-review/issues/176#issuecomment-2325358713). _Originally posted by @lishaduck in https://github.com/jfmengels/node-elm-review/issues/242#issuecomment-2325412189_

First off, how did I hit rate limits without running it? Must've still got something wrong with #310. I'll take a look ASAP. Second off, it luckily looks like most...

Wow, pathe is magic! All tests failing to just one failing because Anonymize needs updates.

@jfmengels, how much do we care about outputting idiomic paths on Windows? Right now, the CLI outputs paths like this: "C:\Somewhere\Foo.txt", but this PR changes that to "C:/Somewhere/Foo.txt", which is...

@jfmengels, can you take a look a the current failure? I'm not really sure why it's different. Is it an prompts thing? I don't think we're doing anything different.

> Is it an prompts thing? Yup. This is silly code: https://github.com/terkelg/prompts/blob/e0519913ec4fcc6746bb3d97d8cd0960c3f3ffde/lib/util/figures.js So we could normalize it, we could try inquirer or Clack or something, IDK, maybe we could monkey-patch...

> Can Windows really not render the characters by default? If I'm reading [this old DevBlogs post](https://devblogs.microsoft.com/commandline/windows-command-line-unicode-and-utf-8-output-text-buffer/) correctly, UTF-8 support for Windows Console landed in 2018, so it should be...

> I would say that it's probably best to change this only it it is nicer for the user in some way, not if it's just for us running it...

> I would be okay with replacing `prompts` with a custom thing as well, but that's a bigger task 😅 I took a closer look at alternatives. Clack is a...