Lionel Henry

It has been deprecated since rlang 0.2.0 (released 4 years ago). It has been renamed to `call2()`. Please also use `!!!` instead of `splice()`.

`slice()` should validate inputs with `vec_as_location()`

11

And call `vec_as_subscript()` first to cause an error with logical inputs.

`dplyr_col_modify()` and recycling

7

I think this call should be in the generic before dispatch, rather than in the `data.frame` method: ```r cols

Take ownership of the `mutate()` step in `group_by()`

4

To simplify the error message: ```r mtcars %>% group_by(cyl = 1 + "") %>% mutate(new = 1 + "") #> Error in `group_by()` at dplyr/R/mutate.R:156:2: #> ! Problem adding computed...

Should pass error calls instead of using `fix_call()`

1

vctrs and tidyselect have been updated to support error calls. We should generally use this instead of `fix_call()`. This should improve backtraces as the trace suffix from the bottom call...

Add `knit_cnd_format()` generic

1

rlang is now in charge of fully printing error messages, including the error prefix. This makes it possible to support more features, such as custom display of condition calls and...

If `layer.diag` and one of `layer.upper` or `layer.lower` are FALSE, there is a whole row and a whole column completely empty. It would make sense not to display those in...

Entrace base errors?

7

This is a follow-up to #229 and how dev rlang always shows a backtrace on error in non-interactive sessions. It might be helpful and more consistent to entrace base errors...

Non-standard use of non-standard evaluation

4

I think capturing expressions in functions like `spread_draws()` obscures the UI in tidybayes. For instance in: ```r m %>% spread_draws(condition_mean[condition], response_sd) ``` It makes sense that we are selecting `condition_mean`...

They currently return the exhaustion sentinel which is not thenable: ```r fn exhausted promises::then(fn(), ~ NULL) #> Error in as.promise.default(promise) : #> Don't know how to convert object of class...