Lionel Henry

Recycle names in `map2()`

1

Closes #779

Because the original implementation was based on `Reduce()` we've accidentally implemented the original `accumulate()` function with automatic simplification. I think ideally `accumulate()` should always return a list and simplification would...

Progress towards r-lib/vctrs#183 Progress towards #758 - Use `vec_simplify()` in `simplify()` and `list_as_vector()` in `as_vector()`. - The `.type` argument of `simplify()` is completely deprecated. - The `.type` argument of `as_vector()`...

To improve rlang backtraces. See https://github.com/r-lib/rlang/issues/1023

For indexing from the end.

Results seem biased towards first expression with very quick benchmarks

2

```r bench::mark( identity(NULL), identity(NA), check = FALSE, iterations = 100000 ) #> # A tibble: 2 × 13 #> expression min median `itr/sec` mem_alloc `gc/sec` n_itr #> #> 1 identity(NULL)...

Variants of `col_` and `style_` functions that return bare strings

3

The attributes of `cli_ansi_string` are a bit cumbersome for programming, they end up in unexpected places and cause issues for comparison, testing, etc. These variants could be suffixed with `_bare()`?...

Casing consistency of theme properties

1

Most properties are dash-cased except these ones which are snake_cased: `vec_last`, `vec_sep`, `vec_trunc`, and `string_quote`. Should the latter be superseded in favour of dash-cased properties?

Caching dark vs light theme makes it harder to create reproducible output

6

If I set `cli_theme_dark` in my RProfile, this changes snapshot outputs where ANSI escapes are enabled. This concerns only a few tests in rlang (most of the tests disable ANSI...

This seems more informative: ``` i Locations 100, 101, 102, ..., 109, and 110 don't exist, there are only 26 elements. ``` Than: ``` i Locations 100, 101, 102, 103,...