Lin Sun

Results 171 comments of Lin Sun

This Iris! It would be great if we can have some automated tests for this - we might already have some, as we'll need this work for every single build....

Awesome, thank you @irisdingbj and @bleggett !

Good point @yuval-k and @howardjohn! So if we do document what to taint and also add the init container to validate the istio-cni is ready on the node (similar as...

Ok I vaguely recall now, thanks! Perhaps for the immediate beta, we should just do init containers? We can add taint if user requests it later on :)

Related cilium doc: https://docs.cilium.io/en/stable/installation/taints/

> i have a PoC that seems to work here https://github.com/istio/istio/compare/master...yuval-k:istio:ambient-init-container-poc?expand=1 > > Once in-pod merges will I continue this and add tests. > > I need a way to...

Hi @jwendell thanks, yep, makes sense. I think starting as env var is okay but we'd like to see you have a longer term plan in place, perhaps in meshConfig...

> Re @hzxuzhonghu's comment. IIUC what this enables is setting up a managed mesh where a user specifies "I want a brand-x gateway" but they get an otherwise totally normal...