istio icon indicating copy to clipboard operation
istio copied to clipboard

Published 20 hours ago • verified publisher icon istio

Add support for rolling update deployment strategy in istio/gateway chart.

Open Collin3 opened this issue 1 year ago • 7 comments

Adds istio/gateway helm chart support for specifying the rolling update deployment strategy. By k8s defaults we end up with a maxUnavailable of 25%, which might be undesirable because you might end up with fewer than the desired pods running during deployments.

  • [ ] Ambient
  • [ ] Configuration Infrastructure
  • [ ] Docs
  • [ ] Dual Stack
  • [x] Installation
  • [ ] Networking
  • [ ] Performance and Scalability
  • [ ] Policies and Telemetry
  • [ ] Security
  • [ ] Test and Release
  • [ ] User Experience
  • [ ] Developer Infrastructure

Collin3 avatar Dec 07 '23 04:12 Collin3

😊 Welcome @Collin3! This is either your first contribution to the Istio istio repo, or it's been a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

istio-policy-bot avatar Dec 07 '23 04:12 istio-policy-bot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Collin3 / name: Collin Neuhaus (0e2535cb0c7c38d86b0c24741a79efbb53a09202)

linux-foundation-easycla[bot] avatar Dec 07 '23 04:12 linux-foundation-easycla[bot]

Hi @Collin3. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing avatar Dec 07 '23 04:12 istio-testing

@Collin3 can you rebase to latest?

linsun avatar Jan 22 '24 15:01 linsun

@linsun sorry, totally missed your comment. I can get this updated today or tomorrow!

Collin3 avatar Feb 22 '24 13:02 Collin3

@linsun I finally got around to rebasing. Sorry for the delay.

Collin3 avatar Mar 01 '24 03:03 Collin3

/ok-to-test

zirain avatar Mar 04 '24 06:03 zirain

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2024-03-04. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

istio-policy-bot avatar Apr 18 '24 06:04 istio-policy-bot

/reopen

akamac avatar Jun 14 '24 11:06 akamac