Lin Sun

Results 168 comments of Lin Sun

I agree with supporting the existing include/exclude annotations (may consider renaming as it is not sidecar any more) as the first step, most common ones folks use are ports related.

adding @EItanya who may have done some work in this area to provide some technical guidance.

> > `Istio WasmDeployment` > > do you mean `WasmPlugin`? Yes WasmPlugin resource, sorry about the name confusion, i have updated the desp.

@kyessenov yep, i suspect there are work related to xDS generation for waypoint related to WasmPlugin, plus create some testing for it.

Thanks @YachikaRalhan!!

Sorry about the delay in replying! I think your analysis makes sense to me, and there is a sematics change in WasmPlugin resource to bind to the waypoint, similar as...

Reopen - needs to validate if this issue is fixed with the new semantics pointed out by @Kaushal28 earlier

For reference, earlier testing discovered https://github.com/istio/istio/issues/47227, which @howardjohn fixed.

@Kaushal28 are you planning to add some tests for this if you are still working on this?