Steven Giesel
Steven Giesel
I updated to preview 7 and the latest changes. I don't think there is much to do right now for us, is there? Therefore, I'd close the ticket. See https://www.nuget.org/packages/bunit/2.0.47-preview
I'll close this as we don't have a gap - feel free to reopen if I missed something here.
Do we want `FindComponents` to be `IReadOnlyCollection` instead of `IReadOnliyList` which it is now? Why would the order matter to a user anyway? How can the user know the order...
> Do we want FindComponents to be IReadOnlyCollection instead of IReadOnliyList which it is now? Forgot what the docs said :D well ignore that comment and ordering makes sense!
> Just wondering if this could be removed, since `string.Concat` seems to do pretty much the same thing, except for the fact that it might box value types. Yes exactly...
> If they are being kept, you should replace `Concat(params T[])` with `Concat(params ReadOnlySpan)` to avoid allocations :) Good point - we could also use `params Span`. The upcoming C#...
> > > If they are being kept, you should replace `Concat(params T[])` with `Concat(params ReadOnlySpan)` to avoid allocations :) > > > > > > Good point - we...
Hey @Joy-less I made a recent change (which will be `v3` as there are smaller breaking changes) that will use `params ReadOnlySpan`. Therefore thanks for the suggestion and I will...
Hey, thanks for reporting that. That was a mistake - sometimes I, locally, don't care about the .net version but want to run the benchmark as baseline. And I checked...
I readded the benchmark