ling1726

Would it be possible to open source license this project ? We'd love to use it in our internal projects !

fix: TableHeaderCell should not render button when not sortable

5

Using the approach with the smallest impact to API and slot rendering. ## Previous Behavior The slot rendered a native `button` always, but with role="presentation" when it was not interactive....

feat: Implement Toast using composition API

5

Implements the `Toast` component using the composition API. Also updates the toast imperative functions to be able to override the root slot. Fixes #27773

react-positioning: figure out a way to handle `focus` forced scrolling for lazy content

3

Lazy loaded content can overflow the boundary of the popper. However calling `focus` before the popper has been repositioned can force a scroll even for viewports where scrolling is disabled....

Related to https://github.com/microsoft/fluentui/issues/26638 Fully implement the Toast component that behaves like the temporary one introduced in #27772

Currently the [AriaLive](https://github.com/microsoft/fluentui/tree/master/packages/react-components/react-toast/src/components/AriaLive) component does not support a root slot, which makes its usage awkward with our Slot types, since event the [UnknownSlotProps type](https://github.com/microsoft/fluentui/blob/d7806642ac5e98ce57d87860e6a0e5f2d5225a4a/packages/react-components/react-utilities/src/compose/types.ts#L27) needs some kind of root to...

Related to https://github.com/microsoft/fluentui/issues/26638 - Toast positions should automatically flip in RTL - Toast positions should also be named like our positioning API with logical values start/end

Can't use children render function in slots without Typescript errors

6

https://codesandbox.io/s/serene-sara-jhil8c?file=/example.tsx ``` (property) icon: { children: () => string; } Type '{ children: () => string; }' is not assignable to type 'WithSlotShorthandValue'. Types of property 'children' are incompatible. Type...

VR test: screenshot diffs in unaffected components

1

This tends to happen quite frequently in VR tests, but here is a concrete example: https://github.com/microsoft/fluentui/pull/27114 changes nothing but the `color` property for datepicker cells. However, the diff includes datepicker...

it's not possible to use css to override the colours of SVG URLs that are used as background images because those SVGs are not actually in DOM and can't be...