fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

VR test: screenshot diffs in unaffected components

Open ling1726 opened this issue 2 years ago • 1 comments

This tends to happen quite frequently in VR tests, but here is a concrete example:

https://github.com/microsoft/fluentui/pull/27114 changes nothing but the color property for datepicker cells. However, the diff includes datepicker header font size being changed. This can be OK. However the red flag 🚨🚨🚨 is that menu screenshots are changing too. Below is the VR run for reference.

https://staticpagerelease.z16.web.core.windows.net/azurestaticapps/vr-fluent/index.html?organization=uifabric&project=fabricpublic&prId=27114&commitId=c5439df15858096d21e252c28680a8bcd7634983&env=prod

ling1726 avatar Mar 08 '23 08:03 ling1726

@TristanWatanabe will ping VR tool team

Hotell avatar May 30 '23 15:05 Hotell

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.