ling1726

Results 35 comments of ling1726

It's hard to say what is 'author order' because once there are multiple invocations of `makeStyles` with media queries then this quickly breaks down. Here is an example where 'author...

A user defined order tha is deterministic can be quite easily achieved with the below code. We also need some documentation in Griffel and Fluent about this ```ts const mediaQueryOrder...

> Is there a default we can apply that will maintain determinism for multiple makeStyles calls and maintain the "author order" within a given makeStyles call? No. That's what I...

we could use `':global(body&)'` and `':global(body &)'` and then simply advertise them 2 in all public docs. We could then add deprecation warnings for `':global(body)'` both at runtime and build...

> But the current behavior is `':global(body &)'`, right? So what you are proposing would be a breaking change. Sorry I meant `':global(body &)'` I've edited the original commet

> I think that we can go with `:global(body&)` and additionally handle `:global(body &)` in the same way as `:global(body)`. But isn't that the breaking change ?

> > But isn't that the breaking change ? > > Why? We will keep `:global(body)` as it is. OK this is funny, just to be clear is this what...

👀 ![image](https://user-images.githubusercontent.com/20744592/183097105-4f77952b-4859-440d-bfd7-6a10ca90d632.png)

The hybrid automated/manual release feels ambitious for beachball, where we already add a bunch of hacks to coexist with the release of v8 in isolation. We should either add the...

This happens because @fluentui/react-conformance-griffel depends on @fluentui/react-conformance. They are released on different cycles. react-conformance is released during the v8 cycle (daily) which does not bump react-conformance-griffel. 1. react-conformance is 1.0.0,...