Juri Leino
Juri Leino
If we implement this it will be a breaking change.
@duncdrum Do you have an idea how to test this properly?
@duncdrum That's what I was looking for :) How does one access the logs of the docker container within GitHub-actions?
What is the default log-level within exist-db stock images?
It's safe to assume `INFO`, I guess. This would limit testability to errors at the moment. If we would really venture into testing the custom log capability we need to...
I think for now it would make sense to just test that certain messages are logged to exist.log and others are not. Or can we access stdout and stderr?
Yes, testing that log output is written to `exist.log` by default needs to be added. But for that the log4j configuration does not need to be altered. If we have...
Aha, in the docker log configuration all messages with level INFO are directed to stdout https://github.com/eXist-db/exist/blob/3ece92c5a1006ace8f9713d378e7393d18471043/exist-docker/src/main/xslt/log4j2-docker.xslt#L33 TIL
From my manual testing I could see that the message format is predictably different, though. Would that suffice, @duncdrum ?
I'll give you an example: When passing `custom-router:log-std#2` to `roaster:route` will result in a call like ```xquery $logger("info", "[f6ad7ba0-8722-431f-ad7b-a08722e31f59] request get /jwt/public/1/2/this/is/just/a/test") ``` This yields following output to stdout ```...