Juri Leino

Results 391 comments of Juri Leino

The whole logging facility has 0 coverage at the moment. Testing docker stdout will bring us a big leap forward.

As @nverwer pointed out this would allow to have custom not-found pages.

@daliboris Hi! It's been a while do you want to change the PR or have questions? Can we help?

I was able to reproduce the incorrect URL by clicking the "Normalised View" checkbox in the top toolbar.

I found the code that is responsible for adding the selectors to the URL. It is `PbView.toggleFeature(ev)`. `registry.getState(this)` will return the array of selectors among all other properties. These properties...

By simply removing the selectors from the properties _before_ calling `registry.commit()` does keep the URL clean and the state can be toggled. ```js // shield URL from selectors delete properties.selectors...

Side note: Initial toggle states are _not_ picked up properly in the client-side demo.

The selectors property is sometimes stored in state and sometimes only in channelState from what I gather.

related https://github.com/eeditiones/tei-publisher-components/issues/149

Notes from our discusssion - Vanilla JS example: https://www.ginzberg.ethz.ch/05_Vol_03_folder_01_001r.xml - OSD plugin example: https://rrss.manuscripta.zrc-sazu.si/rrss_ms_002 Strip shows all facsimiles given to it List of thumbnails Communicates with OSD Must allow to...