Xavier Bonaventura

Understood. Let me know if a contribution could be made before toolchains_llvm fully switches to new rules-based C++ toolchain approach or not. I assume it would take some time to...

Ok, I will explore a bit and see what is best. If there is any work in progress for the new way that is not on master let me know....

I took a first look and the problem at least without rules-based toolchains is that toolchains_llvm depends on `cc_toolchain_config` from rules_cc and that does not support injecting features. https://github.com/bazel-contrib/toolchains_llvm/blob/19dc6cf50de936407198f19e9ffc1af90aef01a7/toolchain/cc_toolchain_config.bzl#L17 https://github.com/bazelbuild/rules_cc/blob/b5a65591334f74371f4d75003768957a740cd868/cc/private/toolchain/unix_cc_toolchain_config.bzl#L1954...

Here is a draft on how the injection in rules_cc for legacy toolchains could look like. If anyone here has an opinion please just comment on it. In the end...

Still relevant

@bjacklyn out of curiosity, are you using prot_library native in your code or the one from rules_proto? Maybe that is the difference?

Thanks @bjacklyn I'm on the same process like you. I updated rules_proto to the latest available in bazel mirror but unfortunately was not having commit `cfdc2fa31879c0aebe31ce7702b1a9c8a4be02d2`. Now I tried to...

I can confirm the same what @bjacklyn was saying, updating rules_proto only is not enough. I still do not have the information of which is the minimum version of com_google_protobuf...

> It also looks like your WORKSPACE is missing the recommended > > ``` > load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps") > > protobuf_deps() > ``` > > patch to fix: > > ```...

Both suggestions work unless you are a Windows user.