buildtools icon indicating copy to clipboard operation
buildtools copied to clipboard

buildifier_test does not complain when passix fix as a mode

Open limdor opened this issue 2 years ago • 1 comments

When passing fix to the lint_mode or mode to buildifier_test, Bazel does not complain. This is not nice from a user point of view.

buildifier_test(
    name = "buildifier",
    size = "small",
    timeout = "short",
    lint_mode = "fix",
    mode = "fix",
    no_sandbox = True,
    workspace = "//:WORKSPACE",
)

I tried with buildtools 6.4.0 and Bazel 7.0.0

limdor avatar Jan 01 '24 12:01 limdor

same here 👍

buildifier_test( name = "buildifier_test", lint_mode = "warn", mode = "check", )

bazel test should fail imo

loeffel-io avatar Sep 17 '24 17:09 loeffel-io

Thank you for contributing to the Bazel Buildtools repository! In order to provide better support for buildtools in 2026 we are currently cleaning up old issues and pull requests. This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

github-actions[bot] avatar Dec 22 '25 07:12 github-actions[bot]

Still relevant

limdor avatar Dec 22 '25 12:12 limdor