Xavier Bonaventura comments

Results 80 comments of


                                            Xavier Bonaventura

Move examples within bazelbuild/bazel into bazelbuild/examples repository

Ok thanks for the feedback. Whose call would be? It would be nice in order to have the example a bit more organized and less spread around.

Enable coverage for generated source files

I can also say that this would be interesting for us.

Enable coverage for generated source files

@c-mita could you please provide an update on this? Is it still under internal review? Thanks

incompatible_default_to_explicit_init_py

> Blocked by #10098 (among other things). @brandjon I think it is also block by https://github.com/bazelbuild/bazel/issues/12238

Support baseline coverage

@sventiffe @c-mita I see that the priority has been lowered and rules-cpp tag added. But I am a bit concerned if baseline coverage is working at all in Bazel with...

Flag --incompatible_disallow_empty_glob will break Bazel skylib in Bazel 1.2.1

PR to make sure that there are no regressions in bazel-skylib. Once it is merged this issue could be closed https://github.com/bazelbuild/bazel-skylib/pull/447

C++ versions less than C++14 are not supported

This is because absl does not support C++ lower than 14

wanted: bazelbuild/buildtools

@fmeum I would also expect to be built from source like any other module. I also think it should have it's own module, if you see the use case that...

[windows] buildifier not found warning but it is working

I just checked with the version 0.8.1 and the current behavior is as follow: - If you do not surround the path with double quotes, it works in both cases...

Buildifier warns about lack of rules_cc; rules_cc says you don't have to use it

I would propose to close this issue. Buildifier is no longer asking for loading rules_cc